Google Git
Sign in
chromium / chromium / src / 9b18f3ea829307a629e34e2f680e2cd3b4f48597
commit9b18f3ea829307a629e34e2f680e2cd3b4f48597[log] [tgz]
authorXiyuan Xia <xiyuan@chromium.org>Thu Nov 16 15:54:32 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 16 15:54:32 2023
treea4a6e3530de59e34ce0aacb1f93d698394436283
parent91abdb72ca4b95f05d4d721a7f0ccd2ab33cc47e [diff]
cc/metrics: AddSortedFrame for trackers pending removal

FrameSequenceTracker and FrameSequenceMetrics do the frame counting
and metrics reported in AddSortedFrame for v3. FrameSorter could
defer AddSortedFrame when frames are out of order. AddSortedFrame
are not called for trackers that are scheduled for termination and
pending removal. This is a problem for short UI animations which
is usually 150ms (about 10 frames). If a frame at start is finished
later, AddSortedFrame would not happen and no metrics are reported
This CL fixes the issue by calling AddSortedFrame for pending
removal trackers as well.

And re-enable disabled overview/splitview tests in ash_unittests.

Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_msan_rel_ng

Bug: b:309800839
Change-Id: I6d8a0464b089f4cb9dd51df9ca85cc16693d65f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5020915
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1225516}
6 files changed
tree: a4a6e3530de59e34ce0aacb1f93d698394436283
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.