Google Git
Sign in
chromium / chromium / src / 7edb45c4ad8cdf06dd825eff88f08f44ff0892e9
commit7edb45c4ad8cdf06dd825eff88f08f44ff0892e9[log] [tgz]
authorMuhammad Salmaan <musalmaan@chromium.org>Wed Jun 11 21:12:22 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 11 21:12:22 2025
tree916128022a598dce59c26aa5fb1951d35aa776ec
parent2759a4fb1d58758d303dfaf9b28e217a1da8893b [diff]
Fix intent chip padding for non-vector icons

This change corrects the padding for the Intent Chip when it displays a
non-vector icon. Previously, the chip used default page action icon
padding, and now the `PageActionView::UpdateBorder()` method checks if
the displayed image is a non-vector icon. If so, it applies the standard
chip padding (LOCATION_BAR_CHILD_INTERIOR_PADDIND vertically and
LOCATION_BAR_CHIP_PADDING horizontally). This ensures visual consistency
with how chip-style buttons were previously padded. Unit tests have been
updated to verify this new padding logic. Screenshot:
https://screenshot.googleplex.com/8t6yzSszQfv3ZTT.png

Bug: 413076423
Change-Id: I79d5907e0fc4dd1468c3553c6a100dbb5dfbf35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6638170
Reviewed-by: Daniel Soromou <koretadaniel@chromium.org>
Commit-Queue: Muhammad Salmaan <musalmaan@chromium.org>
Reviewed-by: Kaan Alsan <alsan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1472676}
2 files changed
tree: 916128022a598dce59c26aa5fb1951d35aa776ec
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.