commit | 7f7be8b6b3daf56814cb6048cfdd6fd89a552c5d | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Thu Mar 21 18:01:04 2019 |
committer | Findit <findit-for-me@appspot.gserviceaccount.com> | Thu Mar 21 18:01:04 2019 |
tree | 4bd100a874cb2b89cb3e026d9bfd99b94a183fd7 | |
parent | e99eb7ace74260b818de214364b803dda03f2c60 [diff] |
Revert "Persist PWA plus install icon across page loads within the app scope" This reverts commit 48a40d8b1b60676e8c1d073f89bdee590f3e9aa2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 642935 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ4YTQwZDhiMWI2MDY3NmU4YzFkMDczZjg5YmRlZTU5MGYzZTlhYTIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/79120 Sample Failed Step: browser_tests Original change's description: > Persist PWA plus install icon across page loads within the app scope > > This CL ensures we remember if a site is within a previously seen > installable scope and avoid flashing the PWA install icon redundantly. > > Navigations between different installable scopes will still refresh > the PWA install icon and animation. > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=383598&signed_aid=00fO__OjzcMdMxXswKP9nQ==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=383599&signed_aid=8T4ag_9niDNF28Q3N_ggYA==&inline=1 > > Bug: 907351 > Change-Id: Ib21542d44fafb7d6777b6782ba1654266d2e582f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514282 > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642935} Change-Id: Ic3b1a42ae9d7fb0fe7b0abeb15d250f530db94b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534114 Cr-Commit-Position: refs/heads/master@{#643012}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .