commit 7f875e6f5e45ccad935a123b9952d0d44234a373
author Dominique Fauteux-Chapleau <domfc@chromium.org> Tue Apr 16 12:42:12 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Apr 16 12:42:12 2024
tree 1cbf28a2df6ff9164b0a719cda7b9966583b0f92
parent 97f412b9fea4b6f52d0783c8d8fb0eef03237aca

Revert "Chrome/Updater: Use the updater scheduler to ensure updater presence."

This reverts commit 6c8d9f199eb403213d463b85787040c0f4736580.

Reason for revert: Breaks mac-rel-ready, see https://ci.chromium.org/ui/p/chrome/builders/ci/mac-rel-ready/14709/overview

Original change's description:
> Chrome/Updater: Use the updater scheduler to ensure updater presence.
>
> The goal of this CL is to simplify and consolidate the number of flows
> that lead to installation of the updater. This reduces contention on
> the updater locks, etc, and may improve the startup performance of
> Chrome and the reliability of the promotion infobar. These changes have
> the following effects:
>
> 1. Installation of the updater and registration of Chrome will happen
>    19 seconds after browser startup, rather than twice during message
>    loop and UI pre-initialization.
> 2. The promotion infobar will be shown at that time, if necessary,
>    rather than right away. This is beneficial in some cases since
>    previously the infobar wouldn't be shown in cases where the profile
>    selection dialog is shown.
> 3. The infobar will be shown on the first run of Chrome if needed.
> 4. The infobar will shown several hours into the browsing session if
>    it did not previously show, or if things have changed and promotion
>    is now needed.
>
> There is still one other path to EnsureUpdater that I did not alter
> here - if Chrome is restarted with a chrome://help tab open, that tab
> will initiate an on-demand update check, installing the updater if
> necessary. Multiple such tabs might cause contention on the locks, but
> do not cause any errors. Performance issues associated with that seem
> infrequent and don't justify additional complexity in my opinion.
>
> Fixed: b/332911252
> Change-Id: Ibdef62b1807f25e7cddaf8f41ab37ca2499cf969
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425369
> Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1287969}

Change-Id: Ieefc91d51599b14dc68371376156331989873f3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457871
Owners-Override: Dominique Fauteux-Chapleau <domfc@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1287980}