Google Git
Sign in
chromium / chromium / src / 7fd640d27b01035de23b11a28467b06cc32b165c
commit7fd640d27b01035de23b11a28467b06cc32b165c[log] [tgz]
authorDana Fried <dfried@chromium.org>Wed Apr 16 21:34:35 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 16 21:34:35 2025
treec196b1ec5936b5cbce908b28aa261f3e48b81f9e
parentd364e54269e89bdd8456e88901f0214a5ead0a7d [diff]
Reland "Fix bug in CookieControlsIconView that was causing test failures"

This reverts commit a14833742ab792e5b440057a78aa9fb3ba29c4e1.

Reason for revert: Leave test disabled. The logic still needs to be fixed.

Bug: b:399817291
Original change's description:
> Revert "Fix bug in CookieControlsIconView that was causing test failures"
>
> This reverts commit 148070f72fd2fe7f72a2868919355c8b73c0b828.
>
> Reason for revert: Causing flaky tests in b/399817291
>
> Original change's description:
> > Fix bug in CookieControlsIconView that was causing test failures
> >
> > Previous code had delayed starting animation until the system was sure
> > an IPH would not be displayed, but there were other code paths that
> > could start the animation while it was queued.
> >
> > This has been fixed with a check for a queued IPH and the affected tests
> > re-enabled.
> >
> > Bug: 398716530
> > Change-Id: I68a11edcfbbe8632a9094a2bf6717aba361b11be
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304101
> > Commit-Queue: Emily Shack <emshack@chromium.org>
> > Auto-Submit: Dana Fried <dfried@chromium.org>
> > Reviewed-by: Emily Shack <emshack@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1425261}
>
> Bug: b:399817291
> Change-Id: Ie0bfd9f982844fabf037796e0c832fef7e438657
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6439310
> Reviewed-by: Dana Fried <dfried@chromium.org>
> Commit-Queue: Michelle Abreo <michelleabreo@google.com>
> Cr-Commit-Position: refs/heads/main@{#1444762}

Bug: b:399817291
Change-Id: I0b0abf7e653c58798a1a9f72f837fc35326faa24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462468
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Michelle Abreo <michelleabreo@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Emily Shack <emshack@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1448017}
2 files changed
tree: c196b1ec5936b5cbce908b28aa261f3e48b81f9e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.