Google Git
Sign in
chromium / chromium / src / 80385055da759cded042b73a9ed90d8b4ad9d934
commit80385055da759cded042b73a9ed90d8b4ad9d934[log] [tgz]
authorDavid Maunder <davidjm@chromium.org>Thu Mar 10 17:28:11 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 10 17:28:11 2022
tree420c3e05e84b6d8dcf75cf7662148c3435f9cb3a
parent1d2555f09e2ec34b4ce78abf0d23929769a5567e [diff]
Ensure ShoppingPersistedTabData is created on UI thread

In the stack trace it suggests a handler is being created for which
Looper.prepare hasn't been called. Creating ShoppingPersistedTabData on
the UI thread will fix this (it should be created there anyway). Also,
ShoppingPersistedTabData.from(..) is used instead of the constructor to
ensure ShoppingPersistedTabData is created once per lifetime of the Tab
and then accessed via the UserDataHost interface.

Bug: 1302792
Change-Id: I614583c2b85b289820444e43903578cbde18de40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3517226
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979828}
1 file changed
tree: 420c3e05e84b6d8dcf75cf7662148c3435f9cb3a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.