commit 807ca06cb81e5eca7ea5b507b28a42b965dbfde1
author Ahmed Elwasefi <a.m.elwasefi@chromium.org> Mon May 27 20:44:14 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 27 20:44:14 2024
tree 479ff606e7c61983810b4c736433fe79cf78fa6b
parent 30926ac294bc66cdadf9ab2a3e58ae7d2ecd0c72

[a11y] Cleaned up legacy code on posting notifications in AXObjectCache.

notifications_to_post_main_ as well as the the whole code-path from PostNotification methods are legacy code which was used to hold dirty events until it's time to serialize.

The old code, used to serialize immediately from notifications_to_post_main_ as seen here:
https://source.chromium.org/chromium/chromium/src/+/5f1daf62a9696d0793eea3c98827836ab617f35f:third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc;l=1705-1710
and
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h;l=949-950;drc=fba455f0b2319c9bec8e8dcf67aa85678ee085d0

However, we currently already hold pending events in deferred queue as well as dirty_objects_ so `notifications_to_post_` no longer has any point but only does extra processing in a middle step.

I also rename `dirty_objects_` to `pending_objects_to_serialize_` to make it easier to tell apart between objects that are dirty pending lifecycle updates and objects pending a serialization.

Change-Id: Ib293e786816301454423d198fff3fcfa67bbc2db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5498335
Auto-Submit: Ahmed Elwasefi (Ahmad45123) <a.m.elwasefi@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1306524}