[compose] Make expandable menu icon depend on suggestion type Another option could be to make the expandable icon a property of the suggestion struct. However since for now this is tied to a popup item id (and I believe it will always be), it is cleaner to make the decision based on it. Design: https://screenshot.googleplex.com/BUyAFBrNgKWHMYY Demo: https://screenshot.googleplex.com/6xstBwFU5s9CVY2 Note: It seems like the design has a bold icon style, I will ask the compose team whether this is indeed the case. If so, we can update it accordingly, such update would not affect what is done in this CL and would likely entail optionally applying a icon style also depending on the popup item id. Bug: b/333929225 Change-Id: Id7fcf227c9046d14016094caf9e666658cacb6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471624 Reviewed-by: Jan Keitel <jkeitel@google.com> Commit-Queue: Bruno Braga <brunobraga@google.com> Cr-Commit-Position: refs/heads/main@{#1291805}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.