Google Git
Sign in
chromium / chromium / src / 80b5a6eaa76a35a7fe19ddce012267a4f34a7f52
commit80b5a6eaa76a35a7fe19ddce012267a4f34a7f52[log] [tgz]
authorMiyoung Shin <myid.shin@igalia.com>Wed Sep 09 02:24:50 2020
committerCommit Bot <commit-bot@chromium.org>Wed Sep 09 02:24:50 2020
treea86fdc2940b747129fd3623621693172c5b53904
parentd4fc79f0a43940e7fe74d0f44255db6f858fbef3 [diff]
Fix regression at chrome://user-actions

This fixes a regression of https://crrev.com/c/2335213 that the user
actions isn't recorded at chrome://user-actions since Javascript is
disallowed in
WebUIImpl::MainFrameNavigationObserver::DidFinishNavigation after
it is allowed in UserActionsUIHandler::ReadyToCommitNavigation.

This CL registers a message called when the page is loaded to allow
the JavaScript and adds the user action callback in OnJavascriptAllowed
instead of ctor not to access RenderFrameHost too early.

Bug: 1122791
Change-Id: I285d62b8fb15ff388c1183e63047efe93705390d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387900
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#805183}
3 files changed
tree: a86fdc2940b747129fd3623621693172c5b53904
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.