commit 810ad6d33efd4d03f50b1fd847de125c20baf01d
author Jing Wang <jiwan@chromium.org> Fri May 03 03:23:28 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri May 03 03:23:28 2024
tree ac88c9667d29391739e240a24a23cdc160f42ff9
parent d7cb43e038a0893a8b267dd93e7c553aa09f7b56

Reland "picker: add metrics for picker start session event"

This reverts commit a44812c4e96868b4542a1da861eafd82b378fa53.

Reason for revert: fixed the test failure in debug mode.

In debug mode, is_component_build is set to true, and because
structured_metrics_client is in a static_library target and picker is
in a component target (ash), structured_metrics_client was duplicated
when linked to ash and ash_unittest.

filed b/337961280 to the metrics team to properly fix the dependency
issue, for now as a work around, we created a static library target
only for session_metrics class.

Original change's description:
> Revert "picker: add metrics for picker start session event"
>
> This reverts commit 38779eb72240033519ac50acf8ac0c7976254450.
>
> Reason for revert:
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/36291/overview
>
> Original change's description:
> > picker: add metrics for picker start session event
> >
> > Bug: b:322927522
> > Change-Id: Idcdedaf53c19c0dd9c11161119a120bd0d04c487
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464640
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Reviewed-by: Jong Ahn <jongahn@chromium.org>
> > Reviewed-by: Darren Shen <shend@chromium.org>
> > Commit-Queue: Jing Wang <jiwan@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1291618}
>
> Bug: b:322927522
> Change-Id: Ib14cd23e75beb5fb57aa144fd3b24da58b0e8dd0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481573
> Owners-Override: Jihad Hanna <jihadghanna@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Jihad Hanna <jihadghanna@google.com>
> Cr-Commit-Position: refs/heads/main@{#1291827}

Cq-Include-Trybots: luci.chromium.try:linux-chromeos-dbg
Bug: b:322927522
Change-Id: Ic620ff5031a8585538b31d74e04d2dae7a42bb6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493185
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jing Wang <jiwan@chromium.org>
Reviewed-by: Jong Ahn <jongahn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1295922}