commit | 8112f045a8c00aca00032fa057be0da38a9c1709 | [log] [tgz] |
---|---|---|
author | Daseul Lee <dslee@chromium.org> | Fri Feb 10 18:55:06 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 10 18:55:06 2023 |
tree | 0ff7bf2d141e178db949763fac854692a76bda19 | |
parent | 9c3a77da9fa8c67b1090ff3c9673c01ab62c0496 [diff] |
Reland "[FSA] Update UNC path rejection to only local UNC path on Windows." This is a reland of commit 01d8e55690c9f59f58c5ae1361d707f08a33be51 Original change's description: > [FSA] Update UNC path rejection to only local UNC path on Windows. > > The previous check `PathIsUNC()` was too broad and included both external/network UNC path as well as local UNC path (i.e. "\\LOCALHOST\c$\..."). As we want to avoid different variants of "local" UNC from bypassing the blocklist check (and that we currently do not have any blocklist on external path), external UNC path will be allowed again with this change. Unfortunately, there is no complete way to normalize different variations of Windows path, so we use some heuristics by checking (1) UNC root via `base::FilePath::IsNetwork()`, (2) hostname, which may represent local system and (3) `$` character in share name. > > Bug: 1326788, 1408321 > Change-Id: I030b2719781ac21a145ceb83ce53e7f129b4ce2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200953 > Reviewed-by: Austin Sullivan <asully@chromium.org> > Commit-Queue: Daseul Lee <dslee@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1101673} (cherry picked from commit 403d13a8451b8a6b75a4d57945e7ada5b5fb52d2) Bug: 1326788, 1408321 Change-Id: I329391304b9afd7ed0160c8bd3e41985e81f4a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4226252 Commit-Queue: Daseul Lee <dslee@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: James Forshaw <forshaw@chromium.org> Reviewed-by: Austin Sullivan <asully@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1101794} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4240562 Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5481_77@{#4} Cr-Branched-From: 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839} Cr-Branched-From: 130f3e4d850f4bc7387cfb8d08aa993d288a67a9-refs/heads/main@{#1084008}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.