Google Git
Sign in
chromium / chromium / src / 815a65cea3f51753cc4788d03d779c5451b0512b
commit815a65cea3f51753cc4788d03d779c5451b0512b[log] [tgz]
authorMarijn Kruisselbrink <mek@chromium.org>Fri Jul 29 19:01:04 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 29 19:01:04 2022
treec0601c0d619eb8cd069adce6c6dfbef717abd66e
parent6ffa23b8e84bcf8fb7e1ecf5d43e3609036cdf0b [diff]
Fix WebAppLaunchProcess's handling of CURRENT_TAB disposition.

If we're trying to launch a web app in the current tab (as the
chrome://apps page sometimes does), we should use whatever the most
recently used tabbed Browser instance was. WebAppLaunchProcess was
incorrectly limiting this search to browsers on the display to use
for new windows instead.

On most platforms this doesn't make a difference, since the default
display for new windows is equal to the display of the most recently
used window, however on Mac the default display for new windows is
always the primary display instead.

Fixed: 1347143
Change-Id: I420d6c8bec67bdafc9a48208c712b759a81ef960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3793569
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1029898}
1 file changed
tree: c0601c0d619eb8cd069adce6c6dfbef717abd66e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.