commit | 8178f37e044ddeb8ffb8ca6224e73f69d4a6075d | [log] [tgz] |
---|---|---|
author | Ben Reich <benreich@chromium.org> | Fri May 20 06:20:53 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 20 06:20:53 2022 |
tree | fa28c5a44f0f85262d89ddc59cf8f4673ab5f678 | |
parent | 148b9b0b861c1684334d697ef0bb8e1f9ba8c98f [diff] |
[FilesTrash] Write .trashinfo files before moving to trash The .trashinfo file contains both the restoration path for a trashed file and the deletion date of the trashed file to enable automatic cleanup (currently done at a 30d interval). At present their is no easy way to utilise the FileSystemOperationRunner to write strings into a new file, so we resort to using base::WriteFile. We first do a verification of uniqueness on the file name in .Trash/files and go to write the same name file into .Trash/info. If it is already present, we can assume the file no longer tracks anything in .Trash/files to remove it. The other big change is updating the idx references to instead track both source_idx and output_idx. Each source will correspond to 1 or 2 outputs, so to ensure we're appropriately setting the error messages on their corresponding output, track them both through the recursion. This also moves some of the anonymous functions to the file_manager::io_task::trash namespace to be leveraged in testing. Bug: b:231830211 Test: unit_tests --gtest_filter=*TrashIOTask* Change-Id: I2310616a03cec7d0321bf3c89f71cd1c70d27ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3632239 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/main@{#1005643}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.