Track PerformanceManager PageNodes in system profiles https://crrev.com/c/4518422 disabled tracking of PageNodes for WebContents in profiles that have Keyed Services disabled (such as the profile picker page in the system profile). This was too restrictive - PerformanceManager also tracks data that doesn't use Keyed Services that should still be enabled. This means that whenever SiteData is looked up for a PageNode, SiteDataCacheFactory and SiteDataCacheFacadeFactory may not exist (if only the system profile is open), and when they do exist, GetDataCacheForBrowserContext() and GetInspectorForBrowserContext() may return nullptr (if the browser context disabled Keyed Services). Therefore this adds tests for nullptr in paths where Keyed Services may be disabled, and explicit CHECK's in paths where they should always be enabled. (Except in the SiteDataCacheFacade class, which is a KeyedService itself and where CHECK'ing every call to SiteDataCacheFacadeFactory::GetInstance() would be too verbose.) R=grt Bug: 1284664 Change-Id: If6684b8230482682ecb9e70d55e4953061f66309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5443769 Commit-Queue: Joe Mason <joenotcharles@google.com> Auto-Submit: Joe Mason <joenotcharles@google.com> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/main@{#1285845}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.