commit | 81ca9863b7da000695af9e623fbd1e92b51d40c9 | [log] [tgz] |
---|---|---|
author | Yaroslav Shalivskyy <yshalivskyy@microsoft.com> | Fri Jan 19 18:57:03 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 19 18:57:03 2024 |
tree | 0a59451909e07c2ce1dd7b297f3ee8076ba8be8a | |
parent | db170b9abc831331a7511fe42390b67cc8d3ce66 [diff] |
Revert "Check NativeThemeFluent doesn't have css colors when HC is on." This reverts commit 0c0c0b555c3ad229c73db212216d3bdbdd2c61d4. Reason for revert: The change causes renderer crashes due to CHECKs when the HC mode on Windows as enabled. The investigation and the implementation of necessary fixes are in progress. Original change's description: > Check NativeThemeFluent doesn't have css colors when HC is on. > > Painting functions in NativeThemeFluent depend on the correct input > from its callers to get the colors for the scrollbars' parts. If > CSS colors are enabled at the same time as forced colors, the function > would override the forced colors in favor of the css ones. > > This CL adds CHECKS in the painting functions to make sure that this > situation doesn't occur. > > Bug: 1495415 > Change-Id: I42d520739d0cb822ce18e00b0b15ec57a4f306da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038216 > Commit-Queue: Gaston Rodriguez <gastonr@microsoft.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#1229642} Bug: 1495415 Change-Id: I7902e1c0a3d39332e607e151e2a3c27ba4afbcac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5215046 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Commit-Queue: Yaroslav Shalivskyy <yshalivskyy@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249420}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.