commit | 81e25a95f6e2133ef999805c0a1556cf696a8015 | [log] [tgz] |
---|---|---|
author | Vasiliy Telezhnikov <vasilyt@chromium.org> | Fri Jan 31 18:18:51 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 31 18:18:51 2025 |
tree | 3ffe490a0038a8bb0d5b4a9f643327dba3910d66 | |
parent | 124f40b2359af6a580e20cf54cc0c6732e428d87 [diff] |
Don't keep reference to the AImage that is not being rendered. AImageReader has a strict limit on the amount of images we can keep around. Normally we set limit to 3 and there are exactly 3 references that we hold: * For visible image in SurfaceFlinger * For pending SurfaceControl transaction to replace visible one * For prepared transaction that we will submit next frame (as we're triple buffering). ImageReader has its own `current_image_ref`, but normally it matches the same image as in prepared transaction. But in some cases early rendering mechanism can trigger rendering a frame that later is not going to be displayed. In this case current_image_ref transiently doesn't match any image on the rendering path, this causes problem, because the image we're going to display can't be acquired because we're at the limit. This CL discards images that we're not planning on displaying. Bug: 40856345 Change-Id: I09c1fe596690f3c7d344a7a23303224e08e737ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219626 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1414240}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.