Google Git
Sign in
chromium / chromium / src / 820b480592ca978073101771414d61203063cfbc
commit820b480592ca978073101771414d61203063cfbc[log] [tgz]
authorMohamed Amir Yosef <mamir@chromium.org>Mon Dec 05 14:36:46 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Dec 05 14:36:46 2022
tree939c750774b95e84aff38d114911eed6d4a03a7c
parentba81d67978e28bb64d8624eb875c7e120518e85d [diff]
[Passwords] Store DB primary key in PasswordForm

This CL is adding the a new int field to the PasswordForm struct that
carries the DB primary key.
This will provide an organic way to uniquely identify passwords in
other layers such as UI.

The field is add an optional field since it will be absent for forms
that aren't yet stored in the DB (e.g. added from settings) or on
platforms that don't use the logins database as a storage layer.

This also updates the PasswordStoreChange() class by omitting the
dedicated field for carrying the primary and relying on the new field
inside PasswordForm

Bug: 1330906
Change-Id: I76e2e4856767ab491de28b1482f0685d1e1074b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4075772
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1079227}
10 files changed
tree: 939c750774b95e84aff38d114911eed6d4a03a7c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.