Remove DCHECK for null callback in phishing classifier This DCHECK initially existed because a single page load would request classification at max once. The CancelPendingClassification function is called whenever a page is finished loading, so it was expected to be null hence the DCHECK. With multiple new triggers, a single page load can have multiple classifications that can occur, so this DCHECK is no longer applicable. Bug: 343247631 Change-Id: I35449ec90da6eb5a2f5826dcbab086cbb51e1837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6105880 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Seung Jae Lim <andysjlim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1398237}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.