commit | 83a262330b4e9cd6b56c7b8d876d0610c2dcbb9d | [log] [tgz] |
---|---|---|
author | François Doray <fdoray@chromium.org> | Wed Jun 02 20:43:10 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 02 20:43:10 2021 |
tree | 5547df786a574064d1d529cb3175fc0323e1f0f3 | |
parent | 4854ec7e2b9cf34bee305017b4bc06e6eed8f117 [diff] |
Revert "Fix delegated ink trails in OOPIF" This reverts commit b8c06872c6cfa5a1be26bd0f801aa1f350538fd7. Reason for revert: crbug.com/1215704 Original change's description: > Fix delegated ink trails in OOPIF > > Today, delegated ink trails do not work in OOPIFs. The > RenderFrameMetadata with the delegated ink flag set on it arrives in a > provider held by RenderWidgetHostImpl that is associated with the OOPIF. > This makes sense, but the issue is that the OOPIF's view is a > RenderWidgetHostViewChildFrame, which does not hold an EventHandler. > Then, when future pointerevents arrive in the browser, they are not > checking the correct widget for a delegated ink flag. Therefore, points > are not being forwarded for delegated ink trails. > > This fix moves the place that we decide to forward delegated ink points > into the RenderWidgetHostInputEventRouter, which is slightly later in > the execution. By doing this, hit testing will have occurred and we > will have the RenderWidgetHostViewChildFrame as the target, allowing us > to directly query that view's widget for a delegated ink flag. Then > forwarding will work as it did from RenderWidgetHostViewEventHandler. > > Bug: 1052145 > Change-Id: I0b22b98ae73be97217c0b45cf2e5c3e6a4e32577 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2857102 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Commit-Queue: Mario Bianucci <mabian@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#888498} Bug: 1052145, 1215704 Change-Id: I501df4b3fe9736cbed5d677ae72906cb331bb347 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2935138 Auto-Submit: François Doray <fdoray@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: François Doray <fdoray@chromium.org> Owners-Override: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#888609}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.