Google Git
Sign in
chromium / chromium / src / 83fa0e2dca77a01b4463b332db14128927ef347d
commit83fa0e2dca77a01b4463b332db14128927ef347d[log] [tgz]
authorSalvador Guerrero <salg@google.com>Thu May 08 22:24:13 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 08 22:24:13 2025
tree876ab553f220a0c7266b80ec10a4dc46fa72ae55
parent4794017cdd99ffe487b3cec9c6b36f9bb8908b33 [diff]
[Adaptive Toolbar] Removed property for alternative highlight

A previous CL (https://crrev.com/c/6496384) fixed an issue with the
contextual page actions button, where the highlight had a square shape.
This was because it was using a generic drawable as the circular
drawable wasn't compatible with the expanded chip state. The CL fixed it
by introducing a drawable that can handle both states.

This CL removes the showBackgroundHighlight property from ButtonData, as
now all buttons use the same background highlight drawable.

This has the effect of fixing the highlight drawable of the reader mode
and price tracking buttons, which were previously left with
showBackgroundHighlight = false by accident.

Bug: 405998788
Change-Id: Ia6e4fd6feff2254979bf115e39656acb30a74a6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519502
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Victor Vianna <victorvianna@google.com>
Commit-Queue: Salvador Guerrero Ramos <salg@google.com>
Cr-Commit-Position: refs/heads/main@{#1457858}
31 files changed
tree: 876ab553f220a0c7266b80ec10a4dc46fa72ae55
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.