commit 848ff70c9e421ab12f4fcc444bd6c6178f7363df
author Andrew Grieve <agrieve@chromium.org> Thu Jan 18 14:57:18 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 18 14:57:18 2024
tree a8810dad476245e9d85e2144d8405463d37e6b3e
parent c6ef8eb4d9038b2532187702572e0f722eddabce

Reland "android: Make arm64 builds HighEnd by default"

This reverts commit af43747f42b8e4cd92542c69abb06d66eecc03df.

Reason for reland: Bot's updated with checkout_pgo_profiles=True

Original change's description:
> Revert "android: Make arm64 builds HighEnd by default"
>
> This reverts commit 0f58e5ed22c50498c4122491520b0720b38c0150.
>
> Reason for revert: Breaking internal CQ. E.g.:
> https://ci.chromium.org/ui/p/chrome/builders/try/android-internal-binary-size/26090/overview
>
> Original change's description:
> > android: Make arm64 builds HighEnd by default
> >
> > The most popular arm64 builds (Trichrome) are shipping with
> > is_high_end_android. The Monochrome arm64 builds are shipped for old
> > devices, and we expect these to gradually become less popular.
> >
> > This change sets is_high_end_android to true for arm64 builds by
> > default.
> >
> > This would make local benchmarking slightly less error prone because
> > there would be a little less to remember to set in GN args when making a
> > build for the most popular official configuration.
> >
> > Known effects:
> >
> > 1. Seemingly all official arm64 builders now explicitly set
> >    is_high_end_android. Hence no effect for them.
> >
> > 2. Non-official arm64 builders will change to become high-end, even the
> >    ones that end up running on old devices (example: android-arm64-rel).
> >    In this patch we make sure that is_high_end_android is ignored for
> >    non-official builds (disabled RELR relocations for non-official).
> >    Hence, no effect here as well.
> >
> > 3. Official builds of Monochrome made by devs would fail to run on
> >    Android pre-P (because RELR support is lacking). This leads to
> >    mysterious crashes during something-dlopen in the Android dynamic
> >    linker. Hopefully nobody does this before we remove support for
> >    Android O.
> >
> > Bug: 1515925
> > Change-Id: I695c98852bb410894144452211aa06cc32ffb141
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5169071
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Commit-Queue: Egor Pasko <pasko@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1247286}
>
> Bug: 1515925
> Change-Id: I7bbf0f2434c41140b8367eb621f3f15c98c01215
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5197794
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1247301}

Bug: 1515925
Change-Id: I2cd85cad17484e78610d0f743a6d56221a7d85e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5200944
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1248754}