Google Git
Sign in
chromium / chromium / src / 84b451eefffb2e648d6f8647a0b2999d16ad6708
commit84b451eefffb2e648d6f8647a0b2999d16ad6708[log] [tgz]
authorJustin Donnelly <jdonnelly@chromium.org>Fri May 03 16:16:26 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 03 16:16:26 2024
treefd3d74ed2a55872e7844f1e82e7a920a06b18342
parent97a2419189a2d22d641b779e80f7591c5db93883 [diff]
[omnibox] Add logging for unknown AutocompleteMatchType.

Converts the NOTREACHED to DUMP_WILL_BE_NOTREACHED_NORETURN so we can
get some logging on what the erroneous type values are without crashing
in official builds.

(cherry picked from commit d96e2e77f698608e8b38bb5c65d092a445260a87)

Bug: 335406606
Change-Id: Ib04f85efbdc3907abf5f97445b8b71b4101fce3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5488882
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Auto-Submit: Justin Donnelly <jdonnelly@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1294612}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512964
Cr-Commit-Position: refs/branch-heads/6422@{#634}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
1 file changed
tree: fd3d74ed2a55872e7844f1e82e7a920a06b18342
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.