Google Git
Sign in
chromium / chromium / src / 84ca77faf44c7c2c80edb5d1f8db3885845da063
commit84ca77faf44c7c2c80edb5d1f8db3885845da063[log] [tgz]
authorDan Harrington <harringtond@chromium.org>Thu May 06 16:38:51 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 06 16:38:51 2021
tree1266b35e6f9cf3a7b7cdbd29ecc7246a81c4e26c
parentd7752f90bc7f8d5fb0cc2071615da8dd095ea5cc [diff]
webfeed: Use compound drawable for unread indicator

The primary goal of this CL is to fix the off-center active tab
indicator provided by TabLayout. The use of ImageView affected
TabLayout's behavior. Setting ImageView to GONE led to problems where
the layout would not be updated after switching back to VISIBLE.
Further, trying to work around this issue by updating the custom view
after any changes led to more problems as setCustomView() doesn't work
well when called multiple times.

Finally, I tried a compound drawable instead of ImageView. This works
better, as the layout is updated when the compound drawable is
modified.

Bug: b/187105312
Change-Id: I9c8a332d8c035e724539c2f450af348101047848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874968
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879871}
7 files changed
tree: 1266b35e6f9cf3a7b7cdbd29ecc7246a81c4e26c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.