Refactor GetEffectiveClientModeAndBrowserForCapturing

This splits up the old GetAppHostForCapturing helper method
into 3 separate methods for the various bits of functionality
it was used for:
- AppBrowserController::FindNoOpenerTabForWebApp, to find an existing
  tab to navigate or focus for a navigate or focus existing launch mode.
- A helper FindNormalBrowser method that returns the most recently
  active "normal" browser in a given profile.
- A bug fix for the existing AppBrowserController::FindForWebApp
  method, to return the most recently active non-popup app browser
  for a given app id.

These 3 pieces are then combined back together in a new
GetEffectiveClientModeAndBrowser method now as part of the
NavigationCapturingProcess class. This does mean that in some
cases we're iterating over all the browsers multiple times
(first to see if there is a tab to capture a focus/navigate existing
navigation, and if there was none a second one to figure out what
browser to open the new tab in), I think this makes the code more
readable and easier to extend to add support for tabbed mode.

Finally, the other place where the old GetEffectiveClientMode
method was used, in the intent-picker focus/navigate existing code,
we call FindNoOpenerTabForWebApp directly, as we're always in the
same branch of the old method in this case.

Bug: 390257745
Change-Id: I64bd3d7f9a1a9a7e687e3c533dd5e3cee58d0ada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6213068
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1414285}
6 files changed
tree: 620fb3b1aa451f42630ece6e75942f9db853fabe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.