commit | 85610229356bfd901b14c98b9fda4ee4bc9f1960 | [log] [tgz] |
---|---|---|
author | Christian Flach <cmfcmf@chromium.org> | Fri Mar 15 17:09:05 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 15 17:09:05 2024 |
tree | 995bcb00af5b4ce9904d0f13b85d20c9d0371627 | |
parent | 1b20f1f8b0e6458d35326c8966bbdb8aa1e109f7 [diff] |
iwa: Add `IwaSource*WithMode::WithFileOp`, rework source inheritance This CL does two things: 1. The new `IwaSource(Bundle)WithMode::WithFileOp` method closes the missing link between sources with mode and sources with mode and file op. 2. We previously inherited all bundle-based sources from `IwaSourceBundle`. This was nice for sharing code and allowing implicit conversions, but allowed you to write code like the following, which doesn't really make sense: ``` IwaSourceBundleProdModeWithFileOp bundle; IwaSourceBundleDevModeWithFileOp new_bundle = bundle.WithDevModeFileOp( IwaSourceBundleDevFileOp::kReference ); ``` With the changes in this CL, you'd have to be more explicit if you _really_ wanted to achieve this: ``` IwaSourceBundleProdModeWithFileOp bundle; IwaSourceBundleDevModeWithFileOp new_bundle( bundle.path(), IwaSourceBundleDevFileOp::kReference ); ``` Bug: None Change-Id: Ibb202bc34f4a56a396270618fca5ba72e53ed123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372845 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Auto-Submit: Christian Flach <cmfcmf@chromium.org> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273492}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.