Revert "HistoryDatabase: improve migration code." This reverts commit bf26f69d67dae2edda3d7cb9e49f1657ebbf2cc1. Reason for revert: cause a large regression on profile loading on startup see: https://uma.googleplex.com/p/chrome/timeline_v2?sid=882662815ae5ed662333e03bed4409d8 Bug: 409355667, 40891923 Original change's description: > HistoryDatabase: improve migration code. > > 1. Delete old migration code. Chromium generally doesn't support > forward-migrating data that is more than 2 years old. This change > deletes migration code that has been live for at least two years. This > reduces binary bloat (-17kB on Android arm32) and removes some migration > anti-patterns, which hopefully will help prevent future code being added > that uses these patterns. See crbug.com/409355667 > > 2. Use compatible version correctly. This value is meant to represent > the oldest version of Chromium *code* that can use the current version > of Chromium *data*, i.e. support for downgrades. Chromium generally > doesn't attempt to support downgrading, but the migrations to v69 and > v70 were backwards compatible, so code for 68 should be fine to run with > data from 69+. This value was not actually being set at all previously. > > 3. Handle failure to update meta table. > > Bug: 409355667, 40891923 > Change-Id: I9901f1d5117e726c116575d742229c6201e70303 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6442189 > Reviewed-by: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Commit-Queue: Evan Stade <evanstade@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#1447350} Bug: 409355667, 40891923 Change-Id: I2bdb4df7649cd93fcd88594d9844f82afc69a007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6681148 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: manuk hovanesian <manukh@chromium.org> Reviewed-by: Evan Stade <evanstade@microsoft.com> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1479848}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.