Google Git
Sign in
chromium / chromium / src / 85c2622952673173d6e7864d9e2728f80edd1987
commit85c2622952673173d6e7864d9e2728f80edd1987[log] [tgz]
authorMike Wittman <wittman@chromium.org>Tue Feb 07 00:50:01 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 07 00:50:01 2023
tree267c735696912066782e7a63eba813f5c6b5d3a8
parent153885e4d0a1ce088ab0e84978513654be72d167 [diff]
Reland "[code health] Remove host created notification use by ClientConnectionManager"

This reverts commit 1ea45d11b9dadfa8467d3578c816047fbf4d9453.

Reason for revert: the crashes were attributable to https://chromium-review.googlesource.com/c/chromium/src/+/4179204 rather than this CL

Original change's description:
> Revert "[code health] Remove host created notification use by ClientConnectionManager"
>
> This reverts commit fa3c9b5f4fa49c8143af3948ca8ad343c472ff38.
>
> Reason for revert: may be causing crashes on creation observation call
>
> Original change's description:
> > [code health] Remove host created notification use by ClientConnectionManager
> >
> > Removes the use of the render process host created notification
> > in ClientConnectionManager. Usage is replaced with the
> > RenderProcessHostCreationObserver.
> >
> > Bug: 357627
> > Change-Id: Id00aa4ffd4602f0a4c9bcb959aff1e807978df50
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4179548
> > Reviewed-by: Joe Mason <joenotcharles@google.com>
> > Commit-Queue: Mike Wittman <wittman@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1095271}
>
> Bug: 357627, 1409290
> Change-Id: Ic0fa41068d66fc2d91381912a655e400f2b221bf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4189878
> Reviewed-by: Joe Mason <joenotcharles@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1095834}

Bug: 357627, 1409290
Change-Id: Ia0a5df57b133353a480c026d4968df2d1f4639b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200541
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1101884}
2 files changed
tree: 267c735696912066782e7a63eba813f5c6b5d3a8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.