Google Git
Sign in
chromium / chromium / src / 860b52a6de901b75e98c4207abec1bb6504909aa
commit860b52a6de901b75e98c4207abec1bb6504909aa[log] [tgz]
authorNoel Gordon <noel@chromium.org>Wed Jun 08 03:08:45 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 08 03:08:45 2022
tree8e7aea1e81177fef4e3459f1b9fd73641589590d
parentec6f891347badc31bbad543b15bf2435e1bfa34c [diff]
filesapp: prevent console.errors due to Recents in MediaStore filter

Per crbug.com/1333385/#c17 when Android MediaStore is enabled in Files
app, console.errors and /var/log/chrome/chrome LOG(ERROR) can occur if
the user presses any Recents button in the files app UI.

Add a FilesFilter to prevent the error. If the feature is enabled, add
a files filter to remove entry from disallowed volumes.

This fix is a mitigation for now. TODO(RECENTS): consider updating the
directoryModel.RecentContentScanner to handle disallowed volumes.

Bug: 1333385, 1334442
Change-Id: I26501d7ac04bb1a6acdfa05b5322111042d20316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3694537
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1011805}
2 files changed
tree: 8e7aea1e81177fef4e3459f1b9fd73641589590d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.