commit 8623c649408a85802b55dab1d47ee482b4f0d9b9
author John Delaney <johnidel@chromium.org> Wed Jan 06 17:37:07 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jan 06 17:37:07 2021
tree 0002067b694ac0e4f9af97e7ae1ab72aa11a7fd2
parent 5e8e592aead097a381da86bdbf73267c0ef0290f

Reland "[conversions] Route impressions alongside rel="noopener" anchor navs"

This is a reland of 53e3903f456a5c3152a022c9a92ed99246a84ebd

This now correctly initializes the was_opener_suppressed_ member on
NavigationRequest.

Original change's description:
> [conversions] Route impressions alongside rel="noopener" anchor navs
>
> What:
> Route impressions for the Conversion Measurement API to the browser
> process for anchor tags with rel="noopener".
>
> Why:
> We currently drop impressions for anchor clicks which have noopener
> set because the impressions do not get forwarded to the browser process.
>
> Anchor click navigations with the rel="noopener" attribute use a
> different navigation path than those without the attribute, in which
> the window creation mojo also navigates the frame to the target url.
> This navigation is not annotated with an impression.
>
> How:
> Add an Impression member to CreateNewWindowParams which will get
> forwarded as a LoadURLParam for the subsequent navigation of the
> window.
>
> This change also fixes a bug in which initiator_frame_tokens are not
> set for noopener navigations.
>
> As of https://chromium-review.googlesource.com/c/chromium/src/+/2327963,
> the lack of an initiator frame tokens are used to to indicate whether
> an opener was suppressed for a navigation. Because attaching the token
> breaks this logic, we route a new |was_opener_suppressed| param through
> the NavigationController:LoadUrlWithParams() flow to recover the
> behavior.
>
> Bug: 1155577
> Change-Id: I84739a9f4ec0df9a867f91397f80b46eea1bcee6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575223
> Commit-Queue: John Delaney <johnidel@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#838275}

Bug: 1155577
Change-Id: I1ab5bf85e62525e898bd9e9a6986ed844a7a5c39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600016
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840653}