Google Git
Sign in
chromium / chromium / src / 8632b3c0daaf17fc6af16ea380a486cdf5e6b01f
commit8632b3c0daaf17fc6af16ea380a486cdf5e6b01f[log] [tgz]
authorDavid Black <dmblack@google.com>Fri May 19 20:15:18 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 19 20:15:18 2023
tree1643beecae4fbfd55ed3eb1225c51f6119d36bfa
parent797257392bd4ef68f4866bef1990fcb0382ec9c2 [diff]
Update help bubble style for Ash.

This CL updates help bubble style for Ash. The most notable change is
to anchoring strategy so that help bubbles will be corner aligned with
their anchor views instead of edge aligned as would otherwise be the
default (see benchmark images linked below).

Note that this CL also removes support for overriding anchor rect
as it is not needed for help bubbles in Ash.

Changes to all help bubbles are:
* Update default corner radius
* Update margins
* Update elevation
* Update typography style
* Update anchoring logic

Changes for nudge style help bubbles are:
* Prevent activation
* Remove close button
* Disallow other buttons

Changes for non-dialog style help bubbles are:
* Updated background color

New benchmark images: http://shortn/_ddVMCy0LWk

Bug: b:282041189
Change-Id: Ied4e991689832019b43be63d08cd04b2ec491d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544331
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1146677}
8 files changed
tree: 1643beecae4fbfd55ed3eb1225c51f6119d36bfa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.