Google Git
Sign in
chromium / chromium / src / 86872834b68c5fa004a3257c49ccd603979c0ffd
commit86872834b68c5fa004a3257c49ccd603979c0ffd[log] [tgz]
authorJérôme Lebel <jlebel@chromium.org>Thu Jul 11 09:11:39 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 11 09:11:39 2024
treeef018c89c6afb9dbad61494509cc837dd0c650c6
parent6763de567e123139903336c0e7b647b235f95097 [diff]
[iOS] Add more logs to sign-in coordinator description

Add more logs to sign-in coordinator description to understand
crbug.com/40071586.

In http://crbug.com/351332013, the DCHECK message is:
<SignInAndHistorySyncCoordinator: 0x405485040, childcoordinator:
<ConsistencyPromoSigninCoordinator: 0x407fb3a80,
defaultAccountCoordinator: 0x408737b60, alertCoordinator: 0x0,
accountChooserCoordinator 0x0, addAccountCoordinator 0x0, presented:
Not presented>, currentStep: 2, accessPoint 41, promoAction 0>

It is unclear how the view controller was not presented. It would
be interesting to understand more about the base view controller.

There is the same issue with AddAccountSigninCoordinator, in
http://crbug.com/351332536.

Bug: 40071586
Change-Id: Iec39b2147d44bfc58d5e3c42cdf01229b14340de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688849
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Menghan Yang <myuu@google.com>
Cr-Commit-Position: refs/heads/main@{#1325999}
2 files changed
tree: ef018c89c6afb9dbad61494509cc837dd0c650c6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.