Revert "Reland "[CodeHealth] Avoid GC-forbidden field in PeerConnectionDependencyFactory"" This reverts commit 5fb945fca94773fb76395821493abaad44d791cb. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5696909970767872 Sample build with failed test: https://ci.chromium.org/b/8761721764142008289 Affected test(s): [ninja://third_party/blink/renderer/controller:blink_unittests_v2/PeerConnectionDependencyFactoryTest.CreateRTCPeerConnectionHandler](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fthird_party%2Fblink%2Frenderer%2Fcontroller:blink_unittests_v2%2FPeerConnectionDependencyFactoryTest.CreateRTCPeerConnectionHandler?q=VHash%3Aa6cd4103710a7e7f) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5696909970767872&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5115838&type=BUG Original change's description: > Reland "[CodeHealth] Avoid GC-forbidden field in PeerConnectionDependencyFactory" > > This is a reland of commit 15dc12665b36eac013f2dde5f180df371dbfd928 > with the fix from > https://chromium-review.googlesource.com/c/chromium/src/+/5096786 > applied. > > Original change's description: > > [CodeHealth] Avoid GC-forbidden field in PeerConnectionDependencyFactory > > > > Make WebrtcVideoPerfReporter garbage-collected, and use HeapMojoRemote > > instead of mojo::Remote there. > > > > Bug: 1426376 > > Change-Id: I778080738c2e9f4b1cb6c015ea29a5205964ba6e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5082441 > > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1233950} > > Bug: 1426376 > Change-Id: Ia3613f903b02817c29d22b5ce6fea3a03564601f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5115838 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Johannes Kron <kron@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1237485} > Bug: 1426376 Change-Id: I8c788a49f40a0fbf6100321b8f2f0e48295e6a5e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5124191 Reviewed-by: Shibalik Mohapatra <shibalik@chromium.org> Owners-Override: Shibalik Mohapatra <shibalik@chromium.org> Commit-Queue: Shibalik Mohapatra <shibalik@chromium.org> Cr-Commit-Position: refs/heads/main@{#1237730}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.