| commit | 86a2631d1a8c81145799505a5821c8b0f5252fbd | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <lukasza@chromium.org> | Tue Jul 20 23:19:25 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jul 20 23:19:25 2021 |
| tree | a383bd4c393e06eb81d436f996aa6c6fa0dd7566 | |
| parent | 8a0c3b43aa28de4d66ac7ea948a6d92591b656c0 [diff] |
Comments highlighting the Hasher struct for unordered maps and sets.
This CL makes minor tweaks to the doc comments of base::IdType<...> and
base::StrongAlias<...> to point out the existence of the Hasher struct
which needs to be used on unordered maps and sets. For example this
doesn't work:
using FooId = base::IdType32<class FooIdTag>;
using Set = std::unordered_set<FooId>;
Instead, one needs to explicitly provide the hasher:
using FooId = base::IdType32<class FooIdTag>;
using Set = std::unordered_set<FooId, typename FooId::Hasher>;
Change-Id: I0f642c4779e5d9486dc514403e22e93fc71a4d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3042359
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#903693}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.