Revert "build: Use -fno-strict-overflow instead of -fwrapv" This reverts commit dc86334c39e93197a89a9201475db12f4b42c9c9. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8724486005851749873 Sample failed build: https://ci.chromium.org/b/8724486005851749873 If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6207309&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8724486005851749873&type=BUG Original change's description: > build: Use -fno-strict-overflow instead of -fwrapv > > In gcc, -fwrapv only controls signed integer overflow, and > -fwrapv-pointer only controls pointer overflow. > > In our current clang, -fwrapv controls both, but in a new > clang [1], clang is moving to match gcc. > > -fno-strict-overflow controls both signed integer and > pointer overflow. Switch to that to get the same behavior for > new clang (and current clang) that we currently have, and to > also give gcc that behavior. > > No intentional behavior change in clang builds. With current > clang, -fwrapv and -fno-strict-overflow should mean the same > thing. > > Once we updated to new clang, we can consider using just > -fwrapv-pointer. > > 1: https://github.com/llvm/llvm-project/pull/122486 > > Bug: 336282133,384391188,389103111 > Change-Id: I6ace8efb4e547ec84ce069c097dce464b15d63ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6207309 > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1412288} > Bug: 336282133,384391188,389103111 Change-Id: I6b6d87fd75059dd782f8a3a16c30a6668e354bb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6208248 Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1412319}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.