| commit | 86c4251ec4f23f6ad33ce41528a4344e8c34c6da | [log] [tgz] |
|---|---|---|
| author | vitaliii <vitaliii@chromium.org> | Wed Jan 29 10:23:09 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 29 10:23:09 2020 |
| tree | a53663059158daefa649c39727ec688cc6022a6b | |
| parent | 5bd704b202104f3b661f37172c504f955f8942dc [diff] |
Revert "Cleanup base::Optional use in Deep Scanning dialog code" This reverts commit 0f668c37d2af88f689fe869d4a800e060bb954b4. Reason for revert: Fails Linux MSan Tests crbug.com/1046693. Original change's description: > Cleanup base::Optional use in Deep Scanning dialog code > > 2 instances of optional can be removed from DeepScanningDialog* code to > make it more readable: > - The access point no longer needs to be optional since all the access > points have been added to Chrome. A default value is still included > in order to simplify tests calling ShowForWebContents. > > - The state variable in DeepScanningDialogViews is better as an enum > than an optional bool indicanting pending/success/failure, especially > since a timeout state is very likely in the future. > > Change-Id: I767db78e428a607a7cc2dfe39d1d63c0f85c30d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020891 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735857} TBR=drubery@chromium.org,domfc@chromium.org Change-Id: Id4814d523935f867ab8fb69942281a6fc8fcf3b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026970 Reviewed-by: vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736302}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .