commit 86ee3c141525f302c7efa399a05aef2549420572
author Yuzu Saijo <yuzus@chromium.org> Thu May 11 01:27:32 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 11 01:27:32 2023
tree b0f4ad2d7b927c9fb79d381e81adf76711dd0cf5
parent 9fec428f3e529e7b33114433d3aaaffbe6fb3891

Revert "[CrOS Cellular] Prevent cyclical shill calls to SetProperties()."

This reverts commit ab32f07a1325fad9385d1328c4ee7a5ba556a0c2.

Reason for revert: Test failure
Bug:1444602

Original change's description:
> [CrOS Cellular] Prevent cyclical shill calls to SetProperties().
>
> Previously, we continuously sent revamp APNs to shill in ApnMigrator's
> NetworkListChanged() when the flag is on, causing NetworkListChanged()
> to be triggered recursively with each update to shill.
>
> This CL adds a stopping condition where if the cellular network has
> already been updated with the revamped APN list in shill, ApnMigrator
> will no longer tell shill to update the network with the revamp
> ApnList.
>
> Note that each time the flag is flipped on, the set that keeps track
> of the networks that APNs have already been sent to in shill will clear
> because ApnMigrator will be constructed each time the flag is enabled
> or disabled.
>
> Fixed: b/280886640
> Test: manual and unittest *ApnMigrator*
> Change-Id: Ia034a2a93f9db6ef52f988e65ee64d9c69e9c996
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4515421
> Reviewed-by: Chad Duffin <chadduffin@chromium.org>
> Commit-Queue: Regan Hsu <hsuregan@chromium.org>
> Reviewed-by: Gordon Seto <gordonseto@google.com>
> Cr-Commit-Position: refs/heads/main@{#1142463}

Change-Id: I993970f9622847bb1b489a5eda3145d4c3059ac5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4520803
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuzu Saijo <yuzus@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Owners-Override: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1142530}