Google Git
Sign in
chromium / chromium / src / ee23c63ddca0c64dede76eb9a63c3a555436f6cf
commitee23c63ddca0c64dede76eb9a63c3a555436f6cf[log] [tgz]
authorJoe DeBlasio <jdeblasio@chromium.org>Tue Mar 19 21:51:49 2019
committerCommit Bot <commit-bot@chromium.org>Tue Mar 19 21:51:49 2019
treedee9b057c4d28be1cca019dacd17334a2a65717a
parent6a44584df0a4ee7abb60914e93254edb57b60631 [diff]
Convert Lookalike URL throttle to use WillStartRequest.

This CL modifies the lookalike URL throttle to block requests before
they happen, rather than after they commit (but before Chrome processes
their response). This keeps logic cleaner (e.g. by not needing to worry
about remembering redirect chains across refreshed requests) at the
expense of possibly showing two interstitials in a row if the URL would
have triggered a different interstitial (as in invalid hostnames).

Bug: 941886
Change-Id: I0b9277b6880cc6c1bf247481ce208f7a42e52b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526806
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642197}
3 files changed
tree: dee9b057c4d28be1cca019dacd17334a2a65717a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .