Google Git
Sign in
chromium / chromium / src / 878a38d65bba32efb67e10e57e0d571bdc304b20
commit878a38d65bba32efb67e10e57e0d571bdc304b20[log] [tgz]
authorMohamed Amir Yosef <mamir@chromium.org>Tue Mar 05 09:12:34 2019
committerCommit Bot <commit-bot@chromium.org>Tue Mar 05 09:12:34 2019
treeadf1a74d11d937485e24bb4595dab64d0cb6d974
parent657a1ca143369198fd860a262b61bb6beaaf9dcd [diff]
[Sync::USS] Unittesting the case of a corrupted password store sync

Some wrong DCHECKs have gone undiscovered for sometime due of the lack
of unit tests of the case when the password store sync fails.

This CL adds some simple unit testing that tests that during initial
merge, if the store fails to add a login or to read all logins, an
error is returned without crashing.

Bug: 936823
Change-Id: Iefd2759b3a73c702c2e9bc4e95c96a43e1ed945c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499543
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637635}
1 file changed
tree: adf1a74d11d937485e24bb4595dab64d0cb6d974
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .