commit 87bffc70bb81d7486bb25a15856c6c36fb018d33
author Brad Peters <brpeters@microsoft.com> Fri May 23 22:04:38 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri May 23 22:04:38 2025
tree 3110b2ec220743bb4eccd012ba3d8fd95806cc5d
parent d26db1628652f32563f159357bcb0038ac8b9ed9

Revert "Close app menu when moving window using hotkeys"

This reverts commit c08a424435edeb00c5a539a6ae38f380adc56548.

The change in the above patch attempted to fix the bug where the
context menu doesn't dismiss when the window moves with
Win+Shift+Arrow, but the fix is incomplete. The fix listens to the
key press event, but Win+Shift+Arrow is an OS special key combination
which is eaten by the OS. This means the application never receives
the key down for arrow when Win and Shift are already pressed. The
above patch is relying on the key up event. So if the user releases
Win or Shift keys before releasing the arrow key, then the context
menu is not dismissed by the above patch. Additionally, the above
patch doesn't handle window moves involving up and down arrow keys
and doesn't handle Win+Arrow movement. Lastly, in a single monitor
setup, Win+Shift+Arrow is a no-opt (it doesn't move the window), but
the above patch dismisses the context menu.

This bug has been addressed by an alternative patch that dismisses
the context menu when the window moves. This aligns the context menu
behavior with other UI like datalist dropdown and select dropdowns.
https://chromium-review.googlesource.com/c/chromium/src/+/6474359

Bug: 394634481
Change-Id: Id9bda026b3b863ab544f5e86f2c0e5f05910dc8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6533281
Reviewed-by: Liang Zhao <lzhao@microsoft.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Brad Peters <brpeters@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1465015}