Google Git
Sign in
chromium / chromium / src / 88130f2e9e943a6e75babff87572b2e0ea18fc85
commit88130f2e9e943a6e75babff87572b2e0ea18fc85[log] [tgz]
authorNicholas Verne <nverne@chromium.org>Tue May 22 05:14:48 2018
committerCommit Bot <commit-bot@chromium.org>Tue May 22 05:14:48 2018
tree17089fea4a5346cb7570cf4e09ae7296d24ca678
parent730d28c16612fb8e12522fee0ebda4df3d748bed [diff]
Fixed a crash at the end of CrostiniInstall

The crash happened when a CrostiniRestarter callback caused the modification of
maps that were currently being iterated, invalidating assumptions of
what can be safely erased. The safe fix is to erase from the maps first,
saving the restarter objects into a temporary vector and then calling the
callbacks from iterating the vector.

Bug: 845227
Change-Id: I64296262d1881122ec89b0083c2f29b4ea354aa9
Reviewed-on: https://chromium-review.googlesource.com/1068301
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560486}
2 files changed
tree: 17089fea4a5346cb7570cf4e09ae7296d24ca678
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .