Google Git
Sign in
chromium / chromium / src / 883276eb0ab8f83c3400c29679eff189b384a55b
commit883276eb0ab8f83c3400c29679eff189b384a55b[log] [tgz]
authorJohannes Henkel <johannes@chromium.org>Thu Feb 20 19:16:20 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 20 19:16:20 2025
tree6122bc238efe2645d8874bbb14bfb86e8963176a
parent6b3558c79ddb879548e98a2068e253f1f4289159 [diff]
Enable wpt/largest-contentful-paint/observe-css-generated-image.html.

This test was imported and then marked as [ Timeout ] from the
beginning.

https://chromium-review.googlesource.com/c/chromium/src/+/5004848/4/third_party/blink/web_tests/TestExpectations
https://chromium-review.googlesource.com/c/chromium/src/+/5004848/4/third_party/blink/web_tests/external/wpt/largest-contentful-paint/observe-css-generated-image.html

Would like to try to fix it:
- Prior to this change, the image was very small in terms of bytes,
  as black-rectangle.png is only 307 bytes. Using one of the lcp-
  images fixes that, so now the element is eligible to be LCP.
- There was also a problem with the performance.now() running after
  the image is already loaded. Therefore this change constructs
  the element that will be styled with the image.

Change-Id: I2c10b3dd39df463933532cee6e7e4cb74169ae25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6285505
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422696}
2 files changed
tree: 6122bc238efe2645d8874bbb14bfb86e8963176a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.