| commit | 883ea257463244b1239fc588ffc8df715f55b78c | [log] [tgz] |
|---|---|---|
| author | Duncan Mercer <mercerd@google.com> | Thu Jun 15 20:26:41 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 15 20:26:41 2023 |
| tree | cc4fddf612884dce93df58b1a2f4bed9db2e560c | |
| parent | 8754f5bb8b79eb55ad87191425ad7a99b78e5dfc [diff] |
[CSC] Fix issue with IPH showing on NTP The issue was caused because on a new tab open, there was no URL yet, so SchemeIs would return false for empty URL. This also fixes a minor issue with Super G sometimes flickering between disabled and enabled state. See: https://screencast.googleplex.com/cast/NTc0Mzk4MTI4MDM2MjQ5NnwxMmJjZGNiYy0yNg Bug: b:286149244 Change-Id: I82aab0abbb22df020634b79d95a7aa09c526cd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616949 Reviewed-by: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Ali Stanfield <stanfield@google.com> Commit-Queue: Duncan Mercer <mercerd@google.com> Cr-Commit-Position: refs/heads/main@{#1158388}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.