commit 88591ea57b6599fc8490b751723c3cda471e67b6
author Adrian Elder <aelder@chromium.org> Thu Aug 04 22:08:01 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Aug 04 22:08:01 2022
tree 15b34b02a03045346ccbc54169b239f7000844e3
parent f8b6efcf6e3e006ec6e154126539ec96283069b9

Revert "Clean up SingleLogFileLogSource::ContinueReadFile"

This reverts commit c31021a2b5fd0484ccdd014127e8a6be27bf2112.

Reason for revert: This change broke CfM log reading and was CPed to a CfM-only branch. As SingleLogFileLogSource is only used in the feedback private api on CfMs, this should be reverted on the main branch and CPed to the relevant CfM branches to mitigate log spamming.

Original change's description:
> Clean up SingleLogFileLogSource::ContinueReadFile
>
> SingleLogFileLogSource::ContinueReadFile is a mess.
>
> In particular, it has a lot of complex code to handle file rotation, but
> the code is unreliable. It's unreliable because it only picks up
> information in the before-rotation file if the class is created before
> the rotation, and because it can only handle a single rotation -- if the
> log file rotates twice between feedbacks, we'll get a very confusing
> snippet of super-old log entries.
>
> Given that, file_ should just be a local variable not a member variable.
> This would also improve thread safety (there's no promise that two calls
> to ReadFile couldn't happen at the same time).
>
> This should make the code much simpler and remove excess if statements.
>
> Bug: b/186687538
> Change-Id: Ie9ede634ba2941c12e4e475255021ea5563c523c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2817963
> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
> Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#880492}

Bug: b/186687538
Change-Id: I673947c329a80e6ad7b4fb34d5bfdf12c1d9c8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792684
Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Commit-Queue: Adrian Elder <aelder@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1031619}