commit | 88a54506e6c7c1f4b49f1cbbf57cb8c6d2536349 | [log] [tgz] |
---|---|---|
author | Marc Treib <treib@chromium.org> | Fri Jul 20 08:16:13 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jul 20 08:16:13 2018 |
tree | 3a6d87deb42cc7465a9715104bc82d295dcced0d | |
parent | 73328290f17495e466623508516e4ecd4f23b126 [diff] |
PeopleHandlerTest: Use ON_CALL instead of EXPECT_CALL where appropriate Most instances of EXPECT_CALL(...).WillRepeatedly(...) don't actually set up any expectation, they just set a return value for the mock function. For this purpose, ON_CALL(...).WillByDefault(...) is more appropriate, and IMO makes the tests easier to read, since it's clearer what the actual expectations are. Bug: none Change-Id: I8b9da317bc24cd10a8349a75d6864808c3cd9a9d Reviewed-on: https://chromium-review.googlesource.com/1141730 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#576809}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .