commit | 890e0ed853756e895e2535c33817be103f0ac07e | [log] [tgz] |
---|---|---|
author | Greg Thompson <grt@chromium.org> | Tue Jan 09 15:24:03 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 09 15:24:03 2024 |
tree | 806df3008fcd8a29edfceccfd0459358291ca7a4 | |
parent | d2b025354f6466af04df4b87826a3751c32aa7f4 [diff] |
Revert "Write did-run to registry asynchronously." This reverts commit 74344b22ad439a57f6f99453c83b9b9ed59813d8. Reason for revert: DCHECK on startup; see notes in bug Original change's description: > Write did-run to registry asynchronously. > > My understanding is that generally we allow registry writes on the main > sequence. However, they can take time if some other application is > calling RegFlushKey (which blocks modifications to the entire hive), or > something else is affecting registry write performance on the machines. > > Since neither the sequencing nor outcome of recording did-run is > relevant to the callers, making the operation non-blocking seems easy > enough. > > Fixed: 1509160 > Change-Id: I3d760bbe13c2b6427705c02524441c1ea0ce87b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5164608 > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1244641} Change-Id: I3044f3ff5183751baacf05a1f36c7572eb82604c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5177401 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1244670}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.