Google Git
Sign in
chromium / chromium / src / 894c76714e57763fc302147ab3bbad1d77d471a3
commit894c76714e57763fc302147ab3bbad1d77d471a3[log] [tgz]
authorForomo Daniel Soromou <koretadaniel@chromium.org>Tue Apr 15 14:29:38 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 15 14:29:38 2025
tree4eb29c6f7bf356096c5d5837f8f6eeb30857115d
parent159662d2a9326423ea59991a0a0b88f071daeef9 [diff]
[PageAction] Migrate Price Insights to the New Page Action Framework

This CL migrates the Price Insights page action to the new page action
framework.

The main entry point is in
`chrome/browser/ui/commerce/commerce_ui_tab_helper.cc`. When a page
action should be shown, the `UpdatePageActionIconView(..)` method is
invoked.

Previously, this would trigger the legacy page action logic. With this
change, the method now requests visibility updates through the new page
action framework.

Existing tests have been updated to validate both the legacy and new
paths, ensuring consistent behavior without changes to expectations.

Bug: 376284009
Change-Id: Ifba34403fa0d577b5cf42f0a7ced4e93d116429b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432646
Reviewed-by: Kaan Alsan <alsan@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Daniel Soromou <koretadaniel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1447094}
15 files changed
tree: 4eb29c6f7bf356096c5d5837f8f6eeb30857115d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.