| commit | 89634a791e90df92028e3ed9703755e5c698390e | [log] [tgz] |
|---|---|---|
| author | Yanling <yanlinghu@google.com> | Thu Apr 17 22:41:41 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 17 22:41:41 2025 |
| tree | 50e1d598e202953c3a6b47e97bda04ee3b63e541 | |
| parent | 754cd7e23d88e5d1d0c5cb25009b16775942d15c [diff] |
Reland: Fix Keyboard interaction with controls in Chrome top toolbar on phones This CL relands the CL (https://chromium-review.googlesource.com/c/chromium/src/+/6437698). The reverted the CL fails to transfer the focus from the fake search box to the url_bar after the user clicking the fake search box. The issue is shown in the video https://drive.google.com/file/d/19DzDcSBSy7qsnTJBsIKplB9lw06O6t6j/view?usp=sharing&resourcekey=0-gIVynJMEatIllcU6C6hN8g. After putting the line 'android:focusableInTouchMode="false"' back to the chrome/android/java/res/layout/fake_search_box_layout.xml, the focus problem on tablet is fixed, which can be verified in the video: https://drive.google.com/file/d/15kudXrqxFc4RA-UwPsBk0tQceAD11iEQ/view?usp=sharing&resourcekey=0-dCo1vzsAwttXPN-vrMp64A. Besides, this reland CL still fixes the issue that the reverted CL addressed on the phone. Bug: 394169187, 394133609 Change-Id: I19dd34b651796f76b8964a00242bfbbf08f9c8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6470323 Reviewed-by: Patrick Noland <pnoland@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Commit-Queue: Yanling Hu <yanlinghu@google.com> Cr-Commit-Position: refs/heads/main@{#1448641}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.