Google Git
Sign in
chromium / chromium / src / 897bc1111ac9f9301c871932b292f73f81cb4d42
commit897bc1111ac9f9301c871932b292f73f81cb4d42[log] [tgz]
authorHiroki Sato <hirokisato@google.com>Thu Jul 29 04:24:39 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 29 04:24:39 2021
treeb7c10652857442434009078a4ce80744bb56c8da
parentf37fb26aa994a4165ac1999e458d266fa1bc3ab4 [diff]
Fix the automation node bounds on an external display

This CL fixes an issue where automation nodes don't have correct
bounds on an external display.

The root cause of this issue is that
AutomationInternalCustomBindings::GetDeviceScaleFactor always returns
the scale factor of the default display. In order to fix this, this CL
ensures that when ViewAccessibility serializes a kChildTreeId property,
it also sets teh scale factor applied to the child tree so that it can
be used in AutomationInternalCustomBindings.

AX-Relnotes: Fixed the bounds of nodes on external display. Accessibility extensions correctly shows the current bounds now.

Bug: 1037968
Bug: b:161758424
Test: Open ash-browser, lacros and ARC++ on an external display. Change the scale factor by ctrl+shift+-/+.

Change-Id: I94a4069efa9bb80070423372ebcace275a4c7bbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000047
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#906566}
8 files changed
tree: b7c10652857442434009078a4ce80744bb56c8da
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.