commit | 89a9a1c6ee64427c47a04a2478a5a67c266fff76 | [log] [tgz] |
---|---|---|
author | Kartar Singh <kartarsingh@google.com> | Fri Jan 10 05:08:16 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 10 05:08:16 2025 |
tree | dbc2faa1c83726e9f801d201de61c4f82c59d5e9 | |
parent | aebd51f7d43b683876a8506b676c848895c1de9f [diff] |
Pass DIP scale from Browser to Viz for MotionEvents creation. We had been using a dummy value of 1 for creating MotionEvent objects in Viz. In this change we are passing the device scale factor as part of touch transfer state. This does add an assumption that the device scale factor remains constant during a touch sequence. Making this assumpiton seems safe since user would have not normally be able to change it mid touch sequence, even if they do it results in activity restart and a touch cancel which terminates touch sequence as stated below. Doing a simple test where I change device scale factor mid sequence using this command: `$ adb shell wm density <value>`. - This results in activity restart and a touch cancel is generated which terminates the sequence. - However one touch move did get the updated device scale factor before touch cancel was received. Bug: 370506271 Change-Id: Ie98ce7096c8edf9fb059374ef5c867dc3fcfb082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6151755 Commit-Queue: Kartar Singh <kartarsingh@google.com> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1404588}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.