Google Git
Sign in
chromium / chromium / src / 89e7c2ac83aba72910806f6afc45616235b5e00d
commit89e7c2ac83aba72910806f6afc45616235b5e00d[log] [tgz]
authorTom Lukaszewicz <tluk@chromium.org>Thu Mar 10 19:00:21 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 10 19:00:21 2022
tree2ece62cbafd6459c8323dc2b43ba9533ec8bb7f0
parent8778d25ab09816aac178211b018a2cdba78effcf [diff]
[side search] Add a side search page action entrypoint

This CL enables Side Search for all desktop platforms aliased by the
toolkit_views buildflag.

This also adds an entrypoint for side search to the omnibox as a page
action icon view. This entrypoint is gated behind the default-disabled
kSideSearchDSESupport flag.

This entrypoint will be visible in the omnibox when the side panel
can be shown (i.e. there is SRP to host in the side panel) and only
when the side panel is closed.

Clicking the page action icon will cause the side panel to open and
the entrypoint to disappear. See mocks below for details.

https://www.figma.com/file/7kHsKCbegnvkE4qgFOUUpT/MWB-Side-Search?node-id=2121%3A32604

Follow up CLs will move the side search side panel to the RHS when
the kSideSearchDSESupport flag is enabled and ensure the RHS side
panel button is toggled while open.

Bug: 1300897
Change-Id: I45f5f665b28ad47c641ac14ae63c3840797ac3e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508639
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Roman Arora <romanarora@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979880}
10 files changed
tree: 2ece62cbafd6459c8323dc2b43ba9533ec8bb7f0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.